Honor parameter information setting for signature help - #8581
Merged
Stella Huang (StellaHuang95) merged 1 commit intoJul 21, 2026
Conversation
Add a Python editor option backed by fAutoListParams and filter automatic LSP signature-help requests while preserving manual invocation and active-session retriggers.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR. |
|
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
| } | ||
|
|
||
| return triggerKind == (int)SignatureHelpTriggerKind.TriggerCharacter || | ||
| triggerKind == (int)SignatureHelpTriggerKind.ContentChange; |
There was a problem hiding this comment.
Please add focused regression coverage for the signature-help suppression matrix. This predicate has several fail-open branches, and tests should distinguish disabled preferences for new automatic TriggerCharacter/ContentChange requests from explicit invocations, retriggers, active sessions, malformed contexts, and unavailable preferences.
Heejae Chang (heejaechang)
approved these changes
Jul 21, 2026
Heejae Chang (heejaechang)
left a comment
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PTVS historically honored Visual Studio's
LANGPREFERENCES.fAutoListParamsvalue before starting parameter information. After signature help moved to the Visual Studio LSP client and Pylance, automatic sessions were instead driven directly by Pylance's advertised trigger characters. As a result, disabling Parameter information no longer affected Python signature help.The stock Statement completion group was later hidden because its other settings are not supported by the current LSP-based experience, so this change exposes only the setting that is now supported.
Fixes #8580
Changes
LANGPREFERENCES2.fAutoListParamsvalue, preserving existing user preferences and Visual Studio settings behavior.textDocument/signatureHelprequests.TriggerCharacterorContentChange) when the option is disabled.LanguagePreferencesservice.Behavior and compatibility
When the option is enabled, signature help behaves exactly as before. Disabling it prevents new automatic popups without disabling the explicit Parameter Info command or interrupting an already active session.
The middle layer handles only
textDocument/signatureHelp; completion, hover, diagnostics, navigation, formatting, and other LSP features are unaffected. Pylance capabilities and configuration are unchanged.ShowCompletionremains disabled, so this does not reintroduce the unsupported stock Auto list members and Hide advanced members controls.Validation
PythonTools.csprojrebuild: succeeded with 0 warnings and 0 errors.git diff --check: clean.Automated tests are not included in this change.